Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should improve our env variable names #1885

Open
infomiho opened this issue Mar 13, 2024 · 0 comments
Open

We should improve our env variable names #1885

infomiho opened this issue Mar 13, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request webdev

Comments

@infomiho
Copy link
Contributor

We have now:

  • REACT_APP_API_URL (client), defines the API url on the client. It uses a legacy prefix from the React Create App days. We should probably go for a tech agnostic prefix e.g. WASP_ and CLIENT_.
  • WASP_WEB_CLIENT_URL (server) defines the client URL that's useful for OAuth.
  • WASP_SERVER_URL (server) defines the server URL that's useful for OAuth.

We should sync the naming between API_URL and SERVER_URL to reduce the possible confusion, since those two are the same thing (server url).

We could do this issue in concert when we do the env vars validation issue which would require us to list out all of the variables and validate them. #1067

@infomiho infomiho added enhancement New feature or request webdev labels Mar 13, 2024
@infomiho infomiho self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webdev
Projects
None yet
Development

No branches or pull requests

1 participant