Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): Replace deprecated nextui component prop onClick with onPress #5851

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Dec 27, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:5318bed-nikolaik   --name openhands-app-5318bed   docker.all-hands.dev/all-hands-ai/openhands:5318bed

@amanape amanape self-assigned this Dec 27, 2024
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 - never liked the click event in most cases. onPress is a good improvement

@amanape amanape merged commit aa60706 into main Dec 31, 2024
15 checks passed
@amanape amanape deleted the chore/nextui-deprecated branch December 31, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants