Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check node.js req for 20.x or later #5877

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

ketan1741
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Fixes node.js version >=20.x requirement in Makefile and Development.md

Link of any specific issues this addresses

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I assume you tested the makefile?

@ketan1741
Copy link
Contributor Author

Thank you! I assume you tested the makefile?

on it, if [ "$${NODE_VERSION_ARRAY[0]}" -gt 20 ] do you want me use ge or gt?

@enyst
Copy link
Collaborator

enyst commented Dec 28, 2024

Not my field, but I must have seen we're using 22 in fact... Cc: @amanape

@ketan1741
Copy link
Contributor Author

ketan1741 commented Dec 28, 2024

Not my field, but I must have seen we're using 22 in fact... Cc: @amanape

yeah I see that here too. But the checks passed for 20.18.1

@ketan1741
Copy link
Contributor Author

@enyst Hey, do we merge this?

@enyst enyst merged commit 194181a into All-Hands-AI:main Dec 29, 2024
12 checks passed
@enyst
Copy link
Collaborator

enyst commented Dec 29, 2024

Sure, thanks!

@amanape
Copy link
Member

amanape commented Dec 30, 2024

Sorry for the late response. The app is confirmed to be supported up to the recommended stable release (v22) of Node. Higher versions break the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants