Fix #5637: Check for errors in IPython content instead of message #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
commented
Dec 29, 2024
|
@neubig I won't be able to actually see this locally for some half a day. I do think this tweak is enough to fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5637 with a simpler approach than PR #5644.
Instead of modifying the backend and adding extensive error detection, we simply check for errors in the content of the IPython output, which is where error messages appear.
The
messageproperty contains a static string, for an iPython obs; thecontentproperty should be filled with the actual content.Changes:
chat-slice.tsto checkipythonObs.contentinstead ofipythonObs.messagefor error detectionThis is a minimal change that addresses the core issue while keeping the codebase simpler.