Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow roll-forward for dotnet-validate #2418

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

martincostello
Copy link
Member

Fix package validation by allowing dotnet-validate to roll-forward to a newer .NET runtime than .NET 6.

Otherwise when the GitHub Actions ubuntu-latest label rolls over to Ubuntu 24.04, .NET 6 will no longer be installed and the job will fail. See actions/runner-images#10636.

Fix package validation by allowing `dotnet-validate` to roll-forward to a newer .NET runtime than .NET 6.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (e8387fb) to head (a8e8742).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
+ Coverage   85.36%   85.39%   +0.02%     
==========================================
  Files         312      312              
  Lines        7464     7464              
  Branches     1121     1121              
==========================================
+ Hits         6372     6374       +2     
+ Misses        906      905       -1     
+ Partials      186      185       -1     
Flag Coverage Δ
linux 85.36% <ø> (ø)
macos 85.36% <ø> (ø)
windows 85.36% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 36bf850 into main Dec 18, 2024
20 checks passed
@martincostello martincostello deleted the dotnet-validate-roll-forward branch December 18, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant