Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playwright monorepo to v1.48.2 #40693

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented Dec 19, 2024

This started as an automated Renovate PR (my first one!), but it seems there are various issues. In particular, there were timeouts on various E2E tests, and Storybook tests failed due to locale bugs (despite running fine locally).

As such, I've set it to match Calypso for now (1.48.2), as they also reported issues: Automattic/wp-calypso#97275


This PR contains the following updates:

Package Type Update Change
@playwright/test (source) devDependencies minor 1.45.1 -> 1.48.2
playwright (source) devDependencies minor 1.45.1 -> 1.48.2
playwright-core (source) devDependencies patch 1.49.0 -> 1.49.1

@matticbot matticbot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the renovate/playwright-monorepo branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack renovate/playwright-monorepo
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin renovate/playwright-monorepo
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [JS Package] Critical Css Gen [JS Package] Storybook [Package] Jetpack mu wpcom WordPress.com Features [Plugin] Automattic For Agencies Client [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tests] Includes Tests E2E Tests RNA labels Dec 19, 2024
@tbradsha tbradsha self-assigned this Dec 19, 2024
@tbradsha tbradsha requested a review from a team December 19, 2024 23:23
@tbradsha tbradsha changed the title Update playwright monorepo to v1.49.1 Update playwright monorepo to v1.48.2 Dec 19, 2024
@matticbot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable upgrade. I wonder what's broken with 1.49 though.

@tbradsha
Copy link
Contributor

I wonder what's broken with 1.49 though.

The two issues I observed:

@tbradsha tbradsha merged commit ea6e9c6 into trunk Dec 20, 2024
78 checks passed
@tbradsha tbradsha deleted the renovate/playwright-monorepo branch December 20, 2024 14:16
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests [JS Package] Critical Css Gen [JS Package] Storybook [Package] Jetpack mu wpcom WordPress.com Features [Plugin] Automattic For Agencies Client [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. RNA [Tests] Includes Tests [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants