Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DispatcherTaskScheduler instead of TaskScheduler.FromCurrentSynchronizationContext #17825

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

Due to TaskScheduler.FromCurrentSynchronizationContext being unreliable on browser workloads, it's safer to explicitly provide dispatcher-based scheduler implementation.

Also, @kekekeks what exactly should be done to ensure correct dispatcher priority? I could read current sync context and check for AvaloniaSynchronizationContext.Priority, if that's what you meant.

Fixed issues

This issue was reported couple of times in telegram chats.

@maxkatz6 maxkatz6 added bug os-browser backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Dec 24, 2024
@maxkatz6 maxkatz6 requested a review from kekekeks December 24, 2024 10:51
@TomEdwardsEnscape
Copy link
Contributor

Can DispatcherTaskScheduler be made public, please? It's something I've wanted from time to time. The workaround today is to call TaskScheduler.FromCurrentSynchronizationContext from the UI thread and store the result somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch bug os-browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants