-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding KeyBinding and MouseBinding #425
base: main
Are you sure you want to change the base?
Conversation
rtazaki
commented
Mar 24, 2024
- Since I created a new page, I modified sidebars.js.
- I didn't know how to preview the Tabs tag, so I implemented it by feel.
- I've never used docusaurus before because I'm not confident in multiple languages, but is it something that document creators must do?
For changes more extensive than modifying/adding words in an existing doc, probably. The CI runs checks for valid syntax/imports, checks md anchor links, image links, etc. Setting up Docusaurus is easy, even if you don't do much web like me. Check the readme on the main page of this repo. Basically: Install Node.js, clone your forked docs repo, npm install, npx docusaurus start. This will start a local web server in dev mode and Docusaurus will hot reload pages as you modify (except the sidebar, IIRC, need to restart for that). You ideally build locally (npm run build --if-present) like the CI does before committing as dev mode will miss certain things like broken anchors. |
- Fixed the issue and confirmed it with Docusaurus.
|
If the PR is accepted, then localizers will work on localizing the text afterwards. There aren't any localized images. At some point soon, I will probably sync the diffs manually for non-localizable parts (ie. code). I would prefer to see some reasoning. eg. Why |
|