test: adding test CI workflow #29
Conversation
wei3erHase
changed the title
|
|
||
| - name: Set Aztec version and start sandbox | ||
| run: | | ||
| VERSION=0.68.0 aztec-up |
There was a problem hiding this comment.
Instead of hardcoding 0.68.0, maybe we can fetch the latest release using something like this step?
There was a problem hiding this comment.
hmm, i was thinking to add it to the update_contract.sh script, but then figured out that is a tool that you use to push the new version
should we fetch the latest version, it'd be incompatible with the package.json one, since the latest one right now is 0.68.2, what do you think?
options are:
- expect the dev to manually update the workflow (doing global search for
0.68.0and replace for0.68.2) - add a snippet in the
update_contract.shthat updates the workflow file - add an api call in the workflows file, that may differ with the
package.jsonversions
There was a problem hiding this comment.
update: implemented it here defi-wonderland#2, had to upgrade the package.json versions as well, because having a non-matching version if aztec-up vs the imported packages makes the accounts "not being registered" error.
wdyt @critesjosh? unless we dynamically create the package json, we'll be always facing this issue where a test could start failing since a new version was released, i'm not pleased about that
There was a problem hiding this comment.
update: reverted the package.json changes by pulling the updated main up branch
chore: merging 68.2
addressing #17, the workflow downloads dependencies and executes
yarn test