-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication service fix #57
base: main
Are you sure you want to change the base?
Communication service fix #57
Conversation
@pandeys1004 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pandeys1004 ,
thanks for the PR but it's not clear what is its intention. It contains a lot of customer-specific configuration and secrets (such as tokens). There are also samples that duplicate the existing samples (email, etc.)
Could you please first open up an issue in the repo where we can discuss the problem and the right approach? Once we agree on the next steps, you can open up a new PR.
@ddematheu2 can you close this for now?
Azure Communication Service fix with changeLog.md file which contains all the changes