-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add federated credentials instructions #1207
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably, this PR is dependent on Azure/bicep-registry-modules#2701
Just creating this comment to make sure the PR is not accidently merged :)
cc: @eriqua
@vhvb1989 Please help review this PR. |
@AlexanderSehr , Azure/bicep-registry-modules#2701 seems weird. It looks like it is creating a list of modules which takes too long for OIDC. I assume that's because the token gets expired and |
'Weird' is a strong word 😄 It's a draft PR and @eriqua is working hard to get OIDC working in it 😉 And yes, it seems that if you use a Service Principal for federated credentials, you run into a timeout after 1h. However, this may not be the same if using a managed identity which is being tested in a different branch. I don't have the details as I've not been working on the code myself, so let's give @eriqua some time to figure the best option out 💪 |
You are totally right. I shouldn't have said I've added some comments to that PR. I think you pointed out the same thing that I was curious about. The use of OIDC and client-secret for the same gh-action called my attention as an interesting approach. I wonder if there could be a way to use only OIDC for all. |
Hey @vhvb1989, Aside from some AZ CLI issue that causes the logic to fail refreshing the token, it seems to work very well with a managed identity. We had a longer chat about the matter yesterday, and it's likely that we'll merge the change in as soon as @eriqua is back (she's currenlty out of office) and enable both the current credential-based as well as the new OIDC approach for authentication (to avoid breaking changes etc.) and after a grace period cut over completely 💪 |
Moving to draft as this would require alignment with the actual implementation (still under testing). Ref Azure/bicep-registry-modules#2792 for latest development |
Overview/Summary
Add federated credentials instructions.
This PR fixes/adds/changes/removes
Add secret setup instructions for SP using federated credentials.
Breaking Changes
none
As part of this Pull Request I have
main
branch@vhvb1989 for notification.