Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feed: Adds id and pk to ChangeFeedMetadata for delete operations #4922

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Change feed: Adds id and pk to ChangeFeedMetadata for delete operations #4922

wants to merge 6 commits into from

Conversation

jcocchi
Copy link
Contributor

@jcocchi jcocchi commented Dec 4, 2024

Pull Request Template

Description

Adds id and partition key to ChangeFeedMetadata. This is populated for delete operations using all versions and deletes change feed mode.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@jcocchi jcocchi marked this pull request as draft December 4, 2024 04:25
@JensSchadron JensSchadron mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

@khdang khdang Awaiting requested review from khdang khdang will be requested when the pull request is marked ready for review khdang is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa will be requested when the pull request is marked ready for review adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh will be requested when the pull request is marked ready for review neildsh is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg will be requested when the pull request is marked ready for review kirillg is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcocchi