Use static readonly arrays for separators #4936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetrou
force-pushed
the
StaticReadonlySeparators
branch
from
74eede4 to
bbda2ec
Compare
gpetrou
requested review from
khdang,
adityasa,
sboshra,
kirankumarkolli,
FabianMeiswinkel and
Pilchie
as code owners
|
@microsoft-github-policy-service agree |
Pilchie
previously approved these changes
Dec 29, 2024
| @@ -113,6 +113,10 @@ internal partial class DocumentClient : IDisposable, IAuthorizationTokenProvider | |||
| private const bool DefaultEnableCpuMonitor = true; | |||
| private const string DefaultInitTaskKey = "InitTaskKey"; | |||
|
|
|||
| private static readonly char[] databaseLinkSeparators = new char[] { '/' }; | |||
| private static readonly char[] sourceDocumentCollectionLinkSeparators = new char[] { '/' }; | |||
There was a problem hiding this comment.
Both Line 116 and 117 can be same which is path separator.
kirankumarkolli
previously approved these changes
Dec 30, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gpetrou
dismissed stale reviews from Pilchie and kirankumarkolli
via
2cb3822
gpetrou
force-pushed
the
StaticReadonlySeparators
branch
from
6666c20 to
2cb3822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Avoid allocating new arrays for separators when splitting strings.
Related code analysis warning https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1861.
Type of change
Small performance-related change.