Query : Fixes OFFSET, LIMIT, TOP data types to match those coming from query plan #4939
+82
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasa
commented
Dec 27, 2024
| @@ -1,7 +1,7 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio Version 16 | |||
| VisualStudioVersion = 16.0.29123.88 | |||
| # Visual Studio Version 17 | |||
adityasa
commented
Dec 27, 2024
| { | ||
| throw new ArgumentException($"{nameof(limit)} must be a non negative number."); | ||
| throw new ArgumentNullException(nameof(limit)); |
adityasa
commented
Dec 27, 2024
| throw new ArgumentOutOfRangeException(nameof(takeCount)); | ||
| } | ||
|
|
||
| this.takeCount = (int)takeCount; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query : Fixes OFFSET, LIMIT, TOP data types to match those coming from query plan
This change ensures that the data types of OFFSET, LIMIT and TOP fields on QueryInfo and HybridSearchQueryInfo objects match those coming from the query plan. Currently the queryplan/service uses ULONG which has a range of 0x00000000 to 0xFFFFFFFF. Since QueryInfo fields use int?, this causes an overflow for a value that's larger than 0x7FFFFFFF for any of these fields.
Type of change
Please delete options that are not relevant.