Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table keyboard navigation fix for Rich Text Editor component #5050

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

vhuseinova-msft
Copy link
Member

What

Update RoosterJS version to fix some issues with keyboard table navigation in Rich Text Editor components

Please see more information in this comment: microsoft/roosterjs#2740 (comment)

Why

How Tested

Storybook

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@vhuseinova-msft vhuseinova-msft requested review from a team as code owners August 19, 2024 23:15
@vhuseinova-msft vhuseinova-msft changed the title Tables keyboard navigation fix for Rich Text Editor component Table keyboard navigation fix for Rich Text Editor component Aug 19, 2024
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Chat bundle size is increased❗.

  • Current size: 2108226
  • Base size: 2107808
  • Diff size: 418

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Calling bundle size is not changed.

  • Current size: 5049927
  • Base size: 5049927
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Aug 19, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6408436
  • Base size: 6408018
  • Diff size: 418

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26504 / 42517
62.33%
26504 / 42517
62.33%
723 / 1309
55.23%
2075 / 3328
62.34%
Current 26499 / 42517
62.32%
26499 / 42517
62.32%
723 / 1309
55.23%
2097 / 3342
62.74%
Diff -5 / 0
-0.01%
-5 / 0
-0.01%
0 / 0
0%
22 / 14
0.4%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53435 / 87048
61.38%
53435 / 87048
61.38%
1077 / 2434
44.24%
3152 / 5199
60.62%
Current 53433 / 87048
61.38%
53433 / 87048
61.38%
1077 / 2434
44.24%
3136 / 5194
60.37%
Diff -2 / 0
0%
-2 / 0
0%
0 / 0
0%
-16 / -5
-0.25%

@vhuseinova-msft vhuseinova-msft merged commit 81eaaab into main Aug 20, 2024
42 checks passed
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/roosterjs-update branch August 20, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants