Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #1388

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix bug #1388

wants to merge 9 commits into from

Conversation

JerryWu1234
Copy link
Contributor

Description

#1330
Add a short description of:

  • what changes you made,
  • why you made them, and
  • any other context that you think might be helpful for someone to better understand what is contained in this pull request.

This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

@JerryWu1234 JerryWu1234 requested a review from samijaber as a code owner March 25, 2024 07:10
Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 0987824

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Major
@builder.io/mitosis-cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 1:43am

@JerryWu1234
Copy link
Contributor Author

image

@JerryWu1234
Copy link
Contributor Author

@samijaber please review

Copy link

nx-cloud bot commented Apr 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0987824. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target test
✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

gitguardian bot commented May 14, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10681816 Triggered Generic High Entropy Secret 1429c73 packages/docs/src/components/search.tsx View secret
8531560 Triggered Generic High Entropy Secret d8610f8 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@JerryWu1234
Copy link
Contributor Author

image

the test'snapshots has to change, because I move all <>
@samijaber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant