Move aerosols to its own type #3492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/aerosol_struct
branch
2 times, most recently
from
bfced1d to
be36f78
Compare
I discussed this in the past with @szy21. We decided that it makes more sense to keep tracers separate because at some point in the future they are not going to be tied to the radiation model. |
Sbozzolo
force-pushed
the
gb/aerosol_struct
branch
3 times, most recently
from
009226c to
91d87a7
Compare
Aerosols were handles by parsing directly the YAML arguments. This led to implicit assumptions, and required aerosols to be handled differently. For example, we had to pass the list `aerosol_names` to `build_cache` even when no aerosol was required. This commit moves aerosol to its own type so that we can follow a more composable approach. It is still not fully possible to swap in a custom, user-defined type because the portion of code in RRTGMPInterface makes assumption on the names of the aerosols. I add error checking for that
Sbozzolo
force-pushed
the
gb/aerosol_struct
branch
from
91d87a7 to
4e760dd
Compare
|
I forgot that symbols are not isbits, so this is currently not GPU compatible. I will work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aerosols were handled by parsing directly the YAML arguments. This led to implicit assumptions, and required aerosols to be handled differently. For example, we had to pass the list
aerosol_namestobuild_cacheeven when no aerosol was required.This commit moves aerosol to its own type so that we can follow a more composable approach. It is still not fully possible to swap in a custom, user-defined type because the portion of code in RRTGMPInterface makes assumption on the names of the aerosols. I add error checking for that