Apply more reproducibility test infra fixes #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
from
f5e996f to
7c4df32
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
from
7c4df32 to
f284709
Compare
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
3 times, most recently
from
0d4bb55 to
1edeeae
Compare
|
Need to remember to increase number of saved folders |
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
3 times, most recently
from
6c5d912 to
53c3156
Compare
|
It looks like one of the saved folders on main was modified: julia> sorted_dirs_with_matched_files()
17-element Vector{String}:
"/central/scratch/esm/slurm-buildkite/climaatmos-main/aa735e9"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/dd35435"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/682335f"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/7eb481f"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/6fa62ee"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/fd0dbb6"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/5f3da9f"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/1b000ca"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/972fdb8"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/17e4eb2"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/8f383d0"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/c1a4aae"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/f1fa690"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/b2b3e7f"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/29ec888"
"/central/scratch/esm/slurm-buil" ⋯ 21 bytes ⋯ "/e84ed15/reproducibility_bundle"
"/central/scratch/esm/slurm-buildkite/climaatmos-main/1624f03"I don't think it's unreasonable that this could happen (e.g., a user looking at and accidentally modified a file). Fixing this algorithmically is a bit complicated because we could either re-touch all of the folders in the order that makes sense, but this really points to the fact that our logic probably shouldn't depend on the order that these files are modified. Instead, I think we can make the simple assertion that the reference counter should always increment by 1, and sort the folders by the reference counter. |
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
2 times, most recently
from
4203ade to
0b7daad
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
from
0b7daad to
167cd55
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
from
167cd55 to
b82ddaa
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
charleskawczynski
force-pushed
the
ck/repro_fixes2
branch
from
b82ddaa to
a0af802
Compare
|
The data was successfully moved in https://buildkite.com/clima/climaatmos-ci/builds/22058#01941881-fe35-4a0a-85bd-24269e667669, so I'm going to manually merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.