Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Center header #115

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

aceburgess
Copy link
Contributor

@afeld @orta

I worked on fixing a different issue earlier for using HTML 5 semantic tags, and then worked on centering the header (only because I thought it may look nice). I was using the HTML 5 semantic tag, but because that's in a separate pull request which hasn't been merged I had to go back on this branch and change the css to reference the class name .navbar instead of the tag name nav.

@aceburgess
Copy link
Contributor Author

By header I now realize I meant navbar.

@afeld
Copy link
Member

afeld commented Apr 27, 2015

Other pull request (#114) got merged, so feel free to update this one.

git checkout center-header
git fetch origin
git merge origin/gh-pages

Also, mind including a screenshot with the new look?

@aceburgess
Copy link
Contributor Author

Sure just merged the gh-pages branch with mine and commited and pushed. Here are the screenshots for the change to the navbar at the top.

screen shot 2015-04-27 at 12 23 34 am
screen shot 2015-04-27 at 12 24 36 am

@afeld
Copy link
Member

afeld commented Apr 27, 2015

Just looking at the changes to the CSS again, I'm a bit confused...it shouldn't take that many new styles to center the nav bar. Is there more to it than that? Also, can we move what's necessary to the 'base' or an even more specific 'nav' file?

@aceburgess
Copy link
Contributor Author

Yes I'll work on this. I added the .navbar selector in the style.scss file, but didn't touch the base.scss file. I only made one new style, but as I'm new to this, not sure what you are seeing, and if something else has changed that I have not noticed. The first commit I made (2fac62f) shows the only thing I changed. Then I fixed the merge conflict and changed the css selector back to the original class name because the other pull request with the HTML 5 tags hadn't been merged yet. Sorry still learning to code, and haven't done much HTML or CSS yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants