Give better error when receiving non-JSON response (#1404)

HoudiniGraphql · Dec 18, 2024 · d6375b6 · d6375b6
1 parent 807bb2b
commit d6375b6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/.changeset/fluffy-lamps-provide.md b/.changeset/fluffy-lamps-provide.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+Throw the semantic HTTP error code and message when receiving a non-JSON error response from the server
diff --git a/packages/houdini/src/runtime/client/plugins/fetch.ts b/packages/houdini/src/runtime/client/plugins/fetch.ts
@@ -94,6 +94,17 @@ const defaultFetch = (
 			},
 		})
 
+		// Avoid parsing the response if it's not JSON, as that will throw a SyntaxError
+		if (
+			!result.ok &&
+			result.headers.get('content-type') !== 'application/json' &&
+			result.headers.get('content-type') !== 'application/graphql+json'
+		) {
+			throw new Error(
+				`Failed to fetch: server returned invalid response with error ${result.status}: ${result.statusText}`
+			)
+		}
+
 		return await result.json()
 	}
 }