include trig, hyptrig functions #22
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
============================================
- Coverage 100.00% 60.65% -39.35%
============================================
Files 3 3
Lines 74 122 +48
============================================
Hits 74 74
- Misses 0 48 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi @JeffreySarnoff , the problem with the trig functions is that there's no fully bi-directional inverse, which is what the current InverseFunctions.jl API expects. Doesn't mean it has to stay that way - we've been talking about we could express something like an "invertible domain" of a function, and there's an open issue about adding right/left inverses (#10). Until now there just hasn't been much pressure (in the form of use cases) to do anything about it. :-) You're very welcome to join in and help figure out a clean but simple way to evolve the package in that direction! CC @devmotion |
|
no problem -- I expected there was a reason .. the inverses get more conformable with complex numbers -- and branchcutting |
|
Feel free to reopen this in the future - would definitely be good to be able to implements inverses for such functions, we just have to figure out a clean way to do it. :-) |
sin(x) <-> asin(x), tanh(x) <-> atanh(x), ...
I was not sure about how you were testing, so there is no change to the tests.