Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: add package option #1233

Merged
merged 1 commit into from
Dec 28, 2024
Merged

fish: add package option #1233

merged 1 commit into from
Dec 28, 2024

Conversation

adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Dec 18, 2024

I want to start testing the new beta and this override seems necessary for full testing.

@adamcstephens
Copy link
Contributor Author

Failing test seems unrelated.

@adamcstephens
Copy link
Contributor Author

Mind reviewing @emilazy ?

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on the latest master?

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution

@Enzime Enzime merged commit 53a0c2f into LnL7:master Dec 28, 2024
6 checks passed
@adamcstephens adamcstephens deleted the fish/package branch December 28, 2024 23:18
@adamcstephens
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants