feat/reg-hints #653
Merged
feat/reg-hints #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for registration-time WebAuthn hints as the new
preferredAuthenticatorTypeargument ingenerateRegistrationOptions(). The following values are supported:'securityKey''localDevice''remoteDevice'Each maps to the following combinations of
PublicKeyCredentialHint(andAuthenticatorAttachmentfor backwards compatibility) in registration options:'securityKey'➡️['security-key']/'cross-platform''localDevice'➡️['client-device']/'platform''remoteDevice'➡️['hybrid']/'cross-platform'WebAuthn hints do allow for multiple values and sorting by "decreasing preference". However I am taking the position here (after taking the same position when we drafted hints into the WebAuthn spec) that the greatest utility of hints comes from being able to fine-tune WebAuthn registration from two ceremonies ("platform, or security key/hybrid") into three ceremonies ("platform, security key, or hybrid".) This means only specifying one hint per ceremony for those RP's that wish for the greater degree of nuance when initiating passkey registration.