chore: updating header to use heading sm #29308
Draft
+40
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Comment on lines
20
to
22
| <p | ||
| class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default" | ||
| <h2 | ||
| class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default" | ||
| /> |
There was a problem hiding this comment.
Add logic to remove the Text component if children is not present
Builds ready [006e636]
Page Load Metrics (1543 ± 90 ms)
Bundle size diffs
|
Builds ready [3392e3d]
Page Load Metrics (1472 ± 21 ms)
Bundle size diffs
|
georgewrmarshall
force-pushed
the
fix/29306/header-update
branch
from
3392e3d to
13f395b
Compare
Comment on lines
-17
to
-23
| <div | ||
| class="mm-box" | ||
| > | ||
| <p | ||
| class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Removes empty p and div tag when children is not present as in the example of the NFT details page header
| as="h6" | ||
| variant={TextVariant.bodyMdMedium} | ||
| > | ||
| <Text onClick={toggleExpanded} variant={TextVariant.bodyMdMedium}> |
There was a problem hiding this comment.
Removes incorrect h6 tag
Comment on lines
+57
to
+70
| {children && ( | ||
| <Text | ||
| as="h2" | ||
| display={Display.Block} | ||
| variant={TextVariant.headingSm} | ||
| textAlign={TextAlign.Center} | ||
| paddingInlineStart={8} | ||
| paddingInlineEnd={8} | ||
| ellipsis | ||
| {...textProps} | ||
| > | ||
| {children} | ||
| </Text> | ||
| )} |
There was a problem hiding this comment.
Adding logic to only render the h2 tag if children exist see ui/components/app/assets/nfts/nft-details/snapshots/nft-full-image.test.js.snap
Builds ready [13f395b]
Page Load Metrics (1597 ± 38 ms)
|
| @@ -29,15 +29,11 @@ exports[`All Connections render renders correctly 1`] = ` | |||
| <div | |||
| class="mm-box" | |||
| > | |||
| <p | |||
| class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default" | |||
| <h2 | |||
There was a problem hiding this comment.
Updating to use heading sm and more correct semantic html
Comment on lines
-80
to
-86
| <Text | ||
| as="span" | ||
| variant={TextVariant.headingMd} | ||
| textAlign={TextAlign.Center} | ||
| > | ||
| {t('permissions')} | ||
| </Text> |
There was a problem hiding this comment.
Removing extra html element to reduce html bloat and to maintain heading consistency
| @@ -28,11 +28,11 @@ exports[`SendPage render and initialization should render correctly even when a | |||
| <div | |||
| class="mm-box" | |||
| > | |||
| <h4 | |||
| <h2 | |||
There was a problem hiding this comment.
Updating header tag
| @@ -28,11 +28,11 @@ exports[`Bridge renders the component with initial props 1`] = ` | |||
| <div | |||
| class="mm-box" | |||
| > | |||
| <h4 | |||
| <h2 | |||
There was a problem hiding this comment.
Updating header tag
Builds ready [8e748b5]
Page Load Metrics (1425 ± 22 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the header component text styling to use semantic HTML and consistent heading styles. The changes include:
<p>to<h2>bodyMdBoldtoheadingSmRelated issues
Partially fixes: #29306
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist