Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CE): form-data loss on navigation #443

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

fix(CE): form-data loss on navigation #443

wants to merge 49 commits into from

Conversation

xyfer17
Copy link
Contributor

@xyfer17 xyfer17 commented Oct 26, 2024

Description

  • Fixed Connector form data loss on navigation (using zustand)
Screen.Recording.2024-10-26.at.11.04.08.PM.mov

Related Issue

#384 Data is getting erased while navigating to other screens

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@macintushar
Copy link
Member

@xyfer17 you can rebase and try. I have pushed the fix for the build error in #481.

// @Mohith93 @sumitd94

github-actions bot and others added 26 commits November 19, 2024 21:31
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add audit logs serializer and audit log permission (Multiw…
dcf1c3b 
…oven#426)

Co-authored-by: TivonB-AI2 <[email protected]>
@subintp @xyfer17
fix(CE): add exception to tracker (Multiwoven#436)
ef1c394
@github-actions @TivonB-AI2 @xyfer17
chore(CE): added audit logs to catalogs_controller (Multiwoven#439)
9f7f06c 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): added audit logs to schedule_sync_controller (Multiwoven#440)
e7fd2c7 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @afthabvp @xyfer17
chore(CE): add data app session model (Multiwoven#438)
23b9de3 
Co-authored-by: afthab vp <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): added audit log to workspace (Multiwoven#442)
45ee172 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add audit logs to factory and roles (Multiwoven#441)
d234817 
Co-authored-by: TivonB-AI2 <[email protected]>
@RafaelOAiSquared @xyfer17
Multiwoven release v0.24.0 (Multiwoven#427)
98b0477 
Co-authored-by: github-actions <[email protected]>
@RafaelOAiSquared @macintushar @xyfer17
Multiwoven release v0.25.0 (Multiwoven#428)
ca5b2b5 
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Tushar Selvakumar <[email protected]>
@RafaelOAiSquared @macintushar @xyfer17
Multiwoven release v0.27.0 (Multiwoven#430)
383365c 
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Tushar Selvakumar <[email protected]>
@RafaelOAiSquared @macintushar @xyfer17
Multiwoven release v0.28.0 (Multiwoven#431)
818cba7 
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Tushar Selvakumar <[email protected]>
@RafaelOAiSquared @macintushar @xyfer17
Multiwoven release v0.29.0 (Multiwoven#432)
c10c637 
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Tushar Selvakumar <[email protected]>
@RafaelOAiSquared @macintushar @xyfer17
Multiwoven release v0.30.0 (Multiwoven#433)
c109963 
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Tushar Selvakumar <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add audit logs to report controller (Multiwoven#446)
9b3634b 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @afthabvp @xyfer17
chore(CE): data app report model changes (Multiwoven#445)
00aab20 
Co-authored-by: afthab vp <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add audit logs to users controller (Multiwoven#449)
73a1987 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add audit to sync records controller (Multiwoven#448)
3723e23 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add audit logs to sync runs controller (Multiwoven#450)
0395e5c 
Co-authored-by: TivonB-AI2 <[email protected]>
@RafaelOAiSquared @xyfer17
Multiwoven release v0.31.0 (Multiwoven#447)
fdb0d24 
Co-authored-by: github-actions <[email protected]>
@RafaelOAiSquared @xyfer17
Multiwoven release v0.32.0 (Multiwoven#453)
9a46d87 
Co-authored-by: github-actions <[email protected]>
@github-actions @afthabvp @xyfer17
chore(CE): add additional_remarks in feedback model (Multiwoven#454)
924daa7 
Co-authored-by: afthab vp <[email protected]>
@xyfer17
feat(CE): Added Mailchimp Destination Connector (Multiwoven#437)
b0a18be 
* feat(CE): Added Mailchimp Destination Connector
@github-actions @afthabvp @xyfer17
fix(CE): data app deletion error fix
6ecba38 
Co-authored-by: afthab vp <[email protected]>
@afthabvp @xyfer17
fix(CE): mailchimp dependency build issue
ba6d8df
@RafaelOAiSquared @xyfer17
Multiwoven release v0.33.0 (Multiwoven#459)
a70219e 
Co-authored-by: github-actions <[email protected]>
@afthabvp @xyfer17
chore(CE): add icons for ais data store and http model (Multiwoven#460)
61edf7c
github-actions bot and others added 22 commits November 19, 2024 21:31
@github-actions @TivonB-AI2 @xyfer17
chore(CE): add timeout to http client (Multiwoven#458)
b276d1c 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @TivonB-AI2 @xyfer17
feat(CE): Add HTTP Model Source Connector (Multiwoven#466)
2fd27d0 
Co-authored-by: TivonB-AI2 <[email protected]>
@github-actions @bvb007 @xyfer17
chore(CE): Dynamic sql model type added (Multiwoven#465)
9626b58 
Co-authored-by: Basil V Bose <[email protected]>
@github-actions @afthabvp @xyfer17
fix(CE): http model config (Multiwoven#464)
8afc338 
Co-authored-by: afthab vp <[email protected]>
@github-actions @afthabvp @xyfer17
feat(CE): AIS Data store destination connector (Multiwoven#462)
47c2af9 
Co-authored-by: afthab vp <[email protected]>
@afthabvp @xyfer17
fix(CE): ais data store icon (Multiwoven#467)
8d57a24
@github-actions @afthabvp @xyfer17
chore(CE): update integration gem version (Multiwoven#457)
ad08480 
Co-authored-by: afthab vp <[email protected]>
@afthabvp @xyfer17
fix(CE): Dockerfile update free tds (Multiwoven#470)
f7dbfda
@bvb007 @xyfer17
feat(CE): added dynamic_sql type to model (#576)
5ebfcc8
@github-actions @xyfer17
chore(CE): Change http model name (Multiwoven#469)
26eef75 
Co-authored-by: TivonB-AI2
@bvb007 @xyfer17
feat(CE): Fetch json_schema from model (#581)
435ff50
@github-actions @xyfer17
chore(CE): Update HTTP Model spec (#583) (Multiwoven#474)
234c1d8 
Co-authored-by: TivonB-AI2
@github-actions @xyfer17
Resolve conflict in cherry-pick of d10fecacbae9908b9ef7e8d08bb1fd3bde…
ebfdd35 
…1e3ef4 and change the commit message (Multiwoven#472)

Co-authored-by: TivonB-AI2
@github-actions @xyfer17
chore(CE): Server Gem Update 0.15.3 (#589) (Multiwoven#471)
17b34d6 
Co-authored-by: TivonB-AI2
@github-actions @bvb007 @xyfer17
feat(CE): fetch data for dsql models (#596) (Multiwoven#476)
a7cb638 
Co-authored-by: Basil V Bose <[email protected]>
@github-actions @xyfer17
chore(CE): Add session id to filter parameter (#591) (Multiwoven#475)
d5e43d8 
Co-authored-by: TivonB-AI2
@github-actions @xyfer17
chore(CE): Change title of AIS Data Store (#585) (Multiwoven#477)
c797034 
Co-authored-by: TivonB-AI2
@RafaelOAiSquared @xyfer17
feat(CE): on_failure report error to AppSignal (Multiwoven#478)
cf716da 
* feat(CE): on_failure report error to AppSignal

* feat(EE): added on_failure to deployment workflows

---------

Co-authored-by: developer-united <[email protected]>
@RafaelOAiSquared @xyfer17
Multiwoven release v0.34.0 (Multiwoven#480)
d3ce365 
Co-authored-by: github-actions <[email protected]>
@macintushar @xyfer17
fix(CE): fixed build error
c584c38
@RafaelOAiSquared @xyfer17
fix(CE): removed reference to build_and_push job
17cd11d 
Co-authored-by: developer-united <[email protected]>
@xyfer17
Merge branch 'main' into bugfix/connector-formData-persistence
cd1abb9
@xyfer17
Copy link
Contributor Author

xyfer17 commented Nov 21, 2024

@xyfer17 you can rebase and try. I have pushed the fix for the build error in #481.

// @Mohith93 @sumitd94

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitd94 sumitd94 Awaiting requested review from sumitd94

@macintushar macintushar Awaiting requested review from macintushar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xyfer17 @macintushar @subintp @RafaelOAiSquared @afthabvp @bvb007