-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a preliminary doc build/publish pipeline #325
base: main
Are you sure you want to change the base?
Conversation
/ok to test |
/ok to test |
/ok to test |
/ok to test |
1 similar comment
/ok to test |
/ok to test |
1 similar comment
/ok to test |
/ok to test |
/ok to test |
/ok to test |
.github/workflows/gh-build-docs.yml
Outdated
id: build | ||
run: | | ||
pushd cuda_python/docs/ | ||
./build_all_docs.sh latest-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This workflow currently only builds the "latest" docs; those with release versions (ex: cuda.bindings 12.6.2) need a separate step that we should add in another PR (once we figure out the release workflow).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic should be as simple as (I could be wrong!)
- Is the doc CI triggered by PRs or merging to main?
- Yes: Only update
latest
- No: Assert this is triggered by a release. Update both
latest
and the latest release version.- TODO: check if we have a way to declare if we only want to update a certain component's docs.
- Yes: Only update
/ok to test |
This is ready for review (after the holidays!). The PR status is set to draft only because of #325 (comment). |
/ok to test |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI in commit 131e7b7 I nuked this file because of this last straw: I see the action panel is a bit messy
/ok to test |
/ok to test |
For now this only updates the "latest" docs, reflecting the changes made in the
main
branch. This is consistent with the behavior of most versioned docs.Part of #169.