Set default parallelism for stage operators to the available number of processors #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundargates
requested review from
calvin681,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
calvin681
reviewed
Jun 15, 2024
| logger.info("initializing {}", computation.getClass().getCanonicalName()); | ||
| computation.init(context); | ||
|
|
||
| // from groups to observable | ||
| final Func2<Context, Observable<T>, Observable<R>> c | ||
| = (Func2<Context, Observable<T>, Observable<R>>) computation; | ||
|
|
||
| if (concurrency == StageConfig.DEFAULT_STAGE_CONCURRENCY) { |
There was a problem hiding this comment.
In this original code, if the concurrency is 1, then you don't need to do a groupBy and flatMap. Which may be more efficient. I feel we should keep that.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For stages that can be executed in parallel, set the default parallelism to the available number of cores.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests