builtins.getFlake: also support path argument #12100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a papercut that has been bugging me for a while. `:lf .` is fine
but doesn't show you what variables it adds to the context. And
`builtins.getFlake (toString ./.)` works but gets tedious after a while.
When inspecting a flake in the repl, the natural thing to do is to call:
x = builtins.getFlake ./.
Before this change, Nix would fail with:
error: expected a string but found a path: /path/to/flake
After this change, Nix automatically coerces the path to a string.
github-actions
bot
added
the
with-tests
zimbatm
requested review from
Ericson2314 and
Mic92
and removed request for
edolstra
hsjobeki
reviewed
Dec 27, 2024
| @@ -69,7 +69,7 @@ EOF | |||
| cat >> "$scriptDir/shebang-inline-expr.sh" <<"EOF" | |||
| #! nix --offline shell | |||
| #! nix --impure --expr `` | |||
| #! nix let flake = (builtins.getFlake (toString ../flake1)).packages; | |||
There was a problem hiding this comment.
Maybe leave this test and add this as a second one so it ensures the backwards compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a papercut that has been bugging me for a while.
:lf .is fine but doesn't show you what variables it adds to the context. Andbuiltins.getFlake (toString ./.)works but gets tedious after a while.Context
When inspecting a flake in the repl, the natural thing to do is to call:
Before this change, Nix would fail with:
After this change, Nix automatically coerces the path to a string.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.