Add SDKAnalysisLevel and UsingMicrosoftNETSdk to the restore telemetry #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nigusu-Allehu
approved these changes
Dec 20, 2024
microsoft-github-policy-service
bot
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
zivkan
reviewed
Dec 28, 2024
| @@ -59,6 +59,8 @@ private readonly Dictionary<RestoreTargetGraph, Dictionary<string, LibraryInclud | |||
| private const string TargetFrameworksCount = nameof(TargetFrameworksCount); | |||
| private const string RuntimeIdentifiersCount = nameof(RuntimeIdentifiersCount); | |||
| private const string TreatWarningsAsErrors = nameof(TreatWarningsAsErrors); | |||
| private const string SDKAnalysisLevel = nameof(SDKAnalysisLevel); | |||
| private const string UsingMicrosoftNETSdk = nameof(UsingMicrosoftNETSdk); | |||
There was a problem hiding this comment.
We should also include NETCoreSdkVersion, otherwise we have no way guess if the customer is using the default SDKAnalysisLevel or if they explicitly set a different value. Without being able to estimate explicit SDKAnalysisLevel usage, I don't know what the point of collecting the telemetry is.
microsoft-github-policy-service
bot
removed
the
Status:No recent activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3075
Description
This will allow to make inferences about the SDKAnalysisLevel usage (a bit of guess work with the default SDK version) and different between legacy and SDK projects in the projectrestoreinformation event.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.