Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] stock_location_product_restriction: Don't check zero quants #2211

Merged
merged 3 commits into from
Dec 31, 2024
Merged

[16.0][IMP] stock_location_product_restriction: Don't check zero quants #2211

merged 3 commits into from
Dec 31, 2024
+153 −15

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Dec 4, 2024 •
edited
Loading

  • Don't check zero quants
  • Improve logging messages

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis force-pushed the 16.0-imp-location-restricion-dro branch 2 times, most recently from 51bc0dd to 04c69d4 Compare December 4, 2024 14:55
@rousseldenis rousseldenis added this to the 16.0 milestone Dec 4, 2024
@rousseldenis rousseldenis force-pushed the 16.0-imp-location-restricion-dro branch from 04c69d4 to ebbd97e Compare December 4, 2024 15:00
@rousseldenis
[IMP] stock_location_product_restriction: Don't take into account zer…
0c9c203 
…o quants

If quant tasks haven't been run, some quants with zero quantities should
not been taken into account when checking the restriction
@rousseldenis
[IMP] stock_location_product_restriction: Don't check zero quants on …
e28db5c 
…locations

For location restriction violation, don't check zero quants
@rousseldenis rousseldenis force-pushed the 16.0-imp-location-restricion-dro branch from ebbd97e to e28db5c Compare December 4, 2024 15:19
lmignon
lmignon approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rousseldenis . LGTM (Code review)

@jbaudoux
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2211-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 31, 2024
@OCA-git-bot
Merge PR #2211 into 16.0
66442b8 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-2211-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 31, 2024
@OCA-git-bot
Merge PR #2211 into 16.0
c162356 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-2211-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 71fc900 into OCA:16.0 Dec 31, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d78f02f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rousseldenis @OCA-git-bot @jbaudoux @lmignon