[16.0][MIG] stock_package_autoload: Migration to 16.0 #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module allows to automatically add the content of a package to the transfer lines
anusriNPS
force-pushed
the
16.0-mig-stock_package_autoload
branch
from
d1514e1 to
57d6aeb
Compare
aleuffre
approved these changes
Dec 17, 2024
Comment on lines
23
to
22
| [ | ||
| ( | ||
| "id", | ||
| "in", | ||
| self.env["stock.quant.package"] | ||
| .search([("quant_ids.product_id", "=", self.product_id.id)]) | ||
| .ids, | ||
| ) | ||
| ] | ||
| if self.product_id |
There was a problem hiding this comment.
question:Would it be possible to avoid the search (line 28) and return
[("quant_ids.product.id", "=", self.product_id.id ])?
anusriNPS
force-pushed
the
16.0-mig-stock_package_autoload
branch
from
57d6aeb to
edb1d64
Compare
aleuffre
suggested changes
Dec 20, 2024
| "category": "Warehouse Management", | ||
| "depends": [ | ||
| "stock", | ||
| "web_domain_field", |
There was a problem hiding this comment.
issue: this module is deprecated, the same can be achieved in base Odoo by using a Binary field. See: https://github.com/OCA/web/blob/16.0/web_domain_field/README.rst
There was a problem hiding this comment.
Sorry on missing to notice the deprecation. Thank you for noticing it.
anusriNPS
force-pushed
the
16.0-mig-stock_package_autoload
branch
from
edb1d64 to
15738ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating stock_package_autoload to 16.0
This module is migrated in 16.0 as this module is introduced as part of this PR in 14.0 : #2027