fix(movielens): properly close browser - fixes #271

StegSchreck · Dec 28, 2023 · e5031d7 · e5031d7
1 parent 51803ce
commit e5031d7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/RatS/movielens/movielens_ratings_parser.py b/RatS/movielens/movielens_ratings_parser.py
@@ -17,7 +17,6 @@ def _call_download_url(self):
         )
 
     def _convert_csv_row_to_movie(self, headers, row):
-
         if self.args and self.args.verbose and self.args.verbose >= 1:
             sys.stdout.write(
                 f"\r===== {self.site.site_displayname}: reading movie from CSV: \r\n"

diff --git a/RatS/utils/browser_handler.py b/RatS/utils/browser_handler.py
@@ -65,13 +65,13 @@ def _create_browser_options(log_level):
         return options
 
     def kill(self):
-        self.browser.service.stop()
         self.browser.stop_client()
         self.browser.close()
         try:
             self.browser.quit()
         except WebDriverException:
             pass
+        self.browser.service.stop()
 
         if self.args and not self.args.show_browser:
             self.display.stop()