Add type-safe layer and filtering #23

aparkersquare · 2024-07-03T08:08:31Z

Add TypedMoneyAddress, Currency and Protocol classes, with values from the DAP spec
Add BtcOnChainAddress, BtcLightningAddress, MobileMoneyAddress
Add TypedMoneyAddressesExample
Add some more doc-strings

Valuable feedback from @cwmyers helped shape the design of this type-safe layer. Thanks Chris!

Synesso · 2024-07-03T08:58:26Z

src/main/kotlin/xyz/block/dap/Dap.kt

+ * - a `handle` which is a unique identifier for the user within the domain
+ * - the `domain` of the DAP registry.


Consider using @Property for the properties, as shown here.

Thanks for the pointer, I've updated to use @Property.

cwmyers

Love it! I'm still in two minds about the registry concept but it has prior art in the dependent APIs so I'm cool with it.

aparkersquare added 6 commits June 28, 2024 22:31

first cut at filtering and concrete types

1db1058

refinements to filtering, move from enums to classes

8cd2cde

rework typed address classes

378d266

package reorg, add more class/method docs

a53d2e8

Fix TypedMoneyAddressRegistry and allow for custom registries

fe60509

rename MoneyAddressRegistry to TypedMoneyAddressRegistry

49aea1f

aparkersquare requested review from cwmyers, frankhinek, jiyoonie9, mistermoe, Synesso and tomdaffurn as code owners July 3, 2024 08:08

add TypedMoneyAddressesExample

afae968

Synesso reviewed Jul 3, 2024

View reviewed changes

use properties for docs, minor tweaks

803eaca

aparkersquare force-pushed the aparker/20240628-typesafe-filtering-layer branch from d131187 to 803eaca Compare July 3, 2024 12:03

update CHANGELOG

279aa82

cwmyers approved these changes Jul 5, 2024

View reviewed changes

aparkersquare merged commit 0062324 into main Jul 5, 2024
2 checks passed

aparkersquare deleted the aparker/20240628-typesafe-filtering-layer branch July 5, 2024 01:07

Provide feedback

		* - a `handle` which is a unique identifier for the user within the domain
		* - the `domain` of the DAP registry.