Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MaxVolumetricSpeed.py #19951

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Nov 24, 2024

The script searches for the retractions and primes and changes the Max E Speed before and after. The speeds of the retracts and primes are not affected. The rest of the gcode will have a limit on the speed of the Extruder.
For example:
M203 E50
G1 F2400 E672.2831
M203 E5
G0 F3600 X248.112 Y134.88
M203 E50
G1 F2400 E672.8831
M203 E5
The script is compatible with Absolute Extrusion and Relative Extrusion and Firmware Retraction. The speed conversion takes filament size into account.

The settings:
image

Description

This is an often requested feature going back to #5248 . Maybe this will fix it. #19998 asked for a Jerk adjustment and that has been added.

This fixes... OR This improves... -->

Type of change

  • [ X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Windows 10Pro with Cura 5.9.0 and 5.8.0

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

The script search for retractions and primes and changes the Max E Speed before and after.  The speeds of the retracts and primes are not affected.  The rest of the gcode will have a limit on the speed of the Extruder.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Nov 24, 2024
@GregValiant GregValiant marked this pull request as draft November 25, 2024 04:25
@wawanbreton
Copy link
Contributor

Thanks, we will take a look when we are not overbusy 😊
For internal reference: CURA-12326

@GregValiant
Copy link
Collaborator Author

I can't recall any of you being "Not overbusy".
I've been going through old feature requests. This one seemed to be doable in post process so I gave it a try.

@wawanbreton
Copy link
Contributor

I can't recall any of you being "Not overbusy".

Sorry for that 😅 we just released 5.9 and we are currently finishing the conan migration, which is a huge work and really needs to be done very soon. So hopefully in a few weeks we can have more time for side-tasks 🙂

@GregValiant
Copy link
Collaborator Author

I'm not pushing. The feature request is many years old so it just doesn't matter. I had the idea for a fix and ran with it.

@wawanbreton
Copy link
Contributor

I know, but it bothers me that we still don't have a decent Cura team and we don't give the community the attention it deserves. 😞

Added a hard "Max E Speed Reset" to the end of the gcode.

Update MaxVolumetricSpeed.py

Revised the regular expression.
@GregValiant GregValiant marked this pull request as ready for review December 4, 2024 21:56
Added Max E Jerk adjustment per Ultimaker#19998 .  It is inserted along with the M203's.

Update to Max Volumetric

Update

Update MaxVolumetricSpeed.py

Minor changes and added an "if" statement when resetting the E-speed as it might not be enabled.
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Test Results

23 370 tests   23 248 ✅  54s ⏱️
     1 suites       2 💤
     1 files       120 ❌

For more details on these failures, see this check.

Results for commit 6b94be0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants