Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sovol Base Bowden Printer" update to add resolveOrValue to retraction_speed override #19983

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HellAholic
Copy link
Contributor

Description

Fixes a crash when opening material management on Sovol SV01
The setting override referred to "machine_max_feedrate_e" which does not resolve on its own and would send a function instead of a value.

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [X ] Run locally from source, A-B test before and after the change.

Test Configuration:

  • Operating System: Win11

Checklist:

@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor labels Dec 1, 2024
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with a bit of defensive programming anyway -- even if a machine setting dependant on a formula feels a bit unsteady.

CURA-12342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: BooBoos 😇 Suggestions for Typos, like the NoMesh or there is a suggested refactor PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants