[wasm-reduce] Reduce struct.new arguments away when possible #7118
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
commented
Nov 26, 2024
| if (tryToReplaceCurrent(structNew)) { | ||
| return; | ||
| } else { | ||
| structNew->operands.swap(operands); |
There was a problem hiding this comment.
This is how I noticed swap was broken...
tlively
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all the fields of a
struct.neware defaultable, see if replacing it with astruct.new_defaultpreserves the behavior, and reduce that way if so.Also add a missing
--closed-worldto the--remove-unused-typesinvocation. Without that, it was erroring and not working, which I
noticed when testing this. The test also checks that.