-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Actions: Bump codecov/codecov-action from 4 to 5 #2510
GH Actions: Bump codecov/codecov-action from 4 to 5 #2510
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
I've reviewed the changelog and migration guide and AFAICS no changes should be needed to the action configuration. However, the new version appears to be buggy (why, of course, it's CodeCov after all) and the Coverage status looks to never be reported back to PRs. This is problematic as it makes CodeCov next to useless for preventing code not covered by tests from going in. This has already been reported upstream and I would recommend NOT merging this PR until the upstream issue has been resolved and the fix is included in a new action runner release. |
sigh Have restarted the builds quite a few times in the mean time at the request of the CodeCov team, but no luck, or rather, things just look to be getting worse. We are now also running into the following issue: codecov/codecov-action#1653 |
I solved that by referencing the token in a different way on Automattic/ad-code-manager. |
I presume you mean by using I have in the mean time also reset the tokens in secrets, but still no luck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twiddled around a bit more (and some more CodeCov 5.x releases later) and it now seems to work.
Note for the future: if at any point the CODECOV_TOKEN
needs to be refreshed/set again, it needs to be done in two places: both in "normal" secrets and also in "Dependabot secrets".
Bumps codecov/codecov-action from 4 to 5.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
5c47607
fix: override commit and pr values for PR cases (#1657)3b1354a
chore(release): 5.0.1 (#1656)2e2a9c6
fix: update tokenless branch logic (#1650)cfc521b
Update README.md0642541
fix: use marketplace v5 badge (#1646)9688725
Update README.md2112eae
chore(deps): bump wrapper to 0.0.23 (#1644)193421c
fixL use the correct source (#1642)6018df7
fix: update container builds (#1640)eff1a64
fix: add missing vars (#1638)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)