Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Unpin Postgres allowing latest v14 version #11047

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d195f34
[WIP] Unpin Postgres on Windows images allowing latest v14 version.
lawrencegripper Nov 26, 2024
95b0a55
re-add signitures
lawrencegripper Nov 26, 2024
181b986
hack: get stdout and stderr for failing install
lawrencegripper Nov 27, 2024
157d0dd
Allow postgres to install necessary MSVC redistributables
lawrencegripper Nov 27, 2024
d3779e8
Merge branch 'main' into lg/postgres-win-update
lawrencegripper Nov 28, 2024
ba0b242
Update images/windows/scripts/helpers/InstallHelpers.ps1
lawrencegripper Nov 28, 2024
1acb48e
Directly install vs redist before installing postgres
lawrencegripper Nov 29, 2024
3f89591
Make install optional as probably not needed for next windows 2025 build
lawrencegripper Nov 29, 2024
a0fc3d1
debugging
lawrencegripper Dec 2, 2024
0d3756a
Handle looking for installer log before exit
lawrencegripper Dec 2, 2024
4e75669
Hack: temp fix to improve debugging loop
lawrencegripper Dec 2, 2024
692b6af
Update images/windows/scripts/helpers/InstallHelpers.ps1
lawrencegripper Dec 3, 2024
9d551e4
Missing backtick 🤦‍♂️
lawrencegripper Dec 3, 2024
1aad2d2
Update images/windows/scripts/build/Install-PostgreSQL.ps1
lawrencegripper Dec 3, 2024
66ee991
Missing recurse
lawrencegripper Dec 4, 2024
18efc23
Quicker loop again
lawrencegripper Dec 4, 2024
0fae0a3
Fix getting output
lawrencegripper Dec 4, 2024
9f19530
Put the installer back to original order
lawrencegripper Dec 4, 2024
3905577
Merge branch 'main' into lg/postgres-win-update
lawrencegripper Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/windows/scripts/build/Install-PostgreSQL.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ if ($null -ne ($toolsetVersion | Select-String -Pattern '\d+\.\d+\.\d+')) {

# Return the previous value of ErrorAction and invoke Install-Binary function
$ErrorActionPreference = $errorActionOldValue
$installerArgs = @("--install_runtimes 0", "--superpassword root", "--enable_acledit 1", "--unattendedmodeui none", "--mode unattended")
$installerArgs = @("--superpassword root", "--enable_acledit 1", "--unattendedmodeui none", "--mode unattended")
Install-Binary `
-Url $installerUrl `
-InstallArgs $installerArgs `
Expand Down
4 changes: 4 additions & 0 deletions images/windows/scripts/helpers/InstallHelpers.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ function Install-Binary {
Write-Host "Installation successful in $installCompleteTime seconds. Reboot is required."
} else {
Write-Host "Installation process returned unexpected exit code: $exitCode"
Write-Host "Standard Output:"
Write-Host $process.StandardOutput.ReadToEnd()
Write-Host "Standard Error:"
Write-Host $process.StandardError.ReadToEnd()
lawrencegripper marked this conversation as resolved.
Show resolved Hide resolved
Write-Host "Time elapsed: $installCompleteTime seconds"
exit $exitCode
}
Expand Down
4 changes: 2 additions & 2 deletions images/windows/toolsets/toolset-2019.json
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@
"version": "18"
},
"postgresql": {
"version": "14.12.1",
"signature": "698BA51AA27CC31282AACA5055E4B9190BC6C0E9"
"signature": "698BA51AA27CC31282AACA5055E4B9190BC6C0E9",
"version": "14"
},
"kotlin": {
"version": "latest"
Expand Down
4 changes: 2 additions & 2 deletions images/windows/toolsets/toolset-2022.json
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@
"version": "8.3"
},
"postgresql": {
"version": "14.12.1",
"signature": "698BA51AA27CC31282AACA5055E4B9190BC6C0E9"
"signature": "698BA51AA27CC31282AACA5055E4B9190BC6C0E9",
"version": "14"
},
"kotlin": {
"version": "latest"
Expand Down