feat: Add OpenLineage support for CloudSQLExecuteQueryOperator #45182
+220
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
kacpermuda
force-pushed
the
feat-ol-google-cloud-sql-operator
branch
3 times, most recently
from
74aa67e to
2782f2f
Compare
kacpermuda
changed the title
kacpermuda
force-pushed
the
feat-ol-google-cloud-sql-operator
branch
from
2782f2f to
e26d1b3
Compare
kacpermuda
changed the title
kacpermuda
force-pushed
the
feat-ol-google-cloud-sql-operator
branch
from
e26d1b3 to
b2b65a3
Compare
kacpermuda
force-pushed
the
feat-ol-google-cloud-sql-operator
branch
2 times, most recently
from
018deab to
9ccb555
Compare
Signed-off-by: Kacper Muda <[email protected]>
kacpermuda
force-pushed
the
feat-ol-google-cloud-sql-operator
branch
from
9ccb555 to
3d8df61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OpenLineage support for CloudSQLExecuteQueryOperator. The logic is very similar (almost the same) as in SQLExecuteQueryOperator where we take advantage of DB hooks being instrumented.
Adding OL required changing sql proxy in the operator to a context manager, probably a nit change.
I do however have some troubles with testing this change in real life. As an addition to my manual tests I've done I wanted to run system tests for CloudSQLExecuteQueryOperator, but they seem to fail even on current main (
breeze testing system-tests providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query.py). Also, the system test dashboard provided by Google is not available, so I can't verify if it fails only for me. Would appreciate any help in running those tests^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.