CASSSIDECAR-181: Ensure memory consistency from PeriodicTask executio… #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and expose richer ScheduleDecision Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-181
yifan-c
commented
Dec 21, 2024
| { | ||
| // TODO: migrate to org.apache.cassandra.sidecar.concurrent.TaskExecutorPool.executeBlocking(java.util.concurrent.Callable<T>, boolean) | ||
| return StopWatch.measureTimeTaken(workerExecutor.executeBlocking(blockingCodeHandler), this::recordTimeTaken); | ||
| return StopWatch.measureTimeTaken(workerExecutor.executeBlocking(blockingCodeHandler, ordered), this::recordTimeTaken); |
There was a problem hiding this comment.
it did not honor the ordered parameter.
yifan-c
commented
Dec 21, 2024
Comment on lines
-69
to
+75
| * @return the identifier of the timer associated with this task | ||
| */ | ||
| public long schedule(PeriodicTask task) | ||
| public void schedule(PeriodicTask task) |
There was a problem hiding this comment.
Use unschedule method to unschedule task. It is improper to use timerID to unschedule, which cancels the need of exposing timerId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ns and expose richer ScheduleDecision
Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-181