change CASNumberCheckDigit and ECNumberCheckDigit, add ECIndexNumberValidator #235
+862
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<b>do not validate</b> the input for length or syntax. So I change CASNumberCheckDigit and ECNumberCheckDigit. And provide CASNumberValidator and ECNumberValidator which validates the syntax.
toCheckDigit and toInt which handles 'X' converted to 10, resp. from 10 This methods can be used in ISBN10CheckDigit, ISSNCheckDigit and ECIndexNumberCheckDigit
The European Community index number is a unique nine-digit identifier that is assigned to hazardous chemical substances.
Conflicts: src/main/java/org/apache/commons/validator/routines/checkdigit/CASNumberCheckDigit.java src/main/java/org/apache/commons/validator/routines/checkdigit/ECNumberCheckDigit.java src/test/java/org/apache/commons/validator/routines/checkdigit/CASNumberCheckDigitTest.java src/test/java/org/apache/commons/validator/routines/checkdigit/ECNumberCheckDigitTest.java
|
Please use separate PRs for each independent change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routines in package
org.apache.commons.validator.routines.checkdigitdo not validate the input for length or syntax. This is documented in
package-infoRespected this idea I change CASNumberCheckDigit and ECNumberCheckDigit.
And provide CASNumberValidator and ECNumberValidator which validates the syntax.
I also add a Validator for ECIndexNumber, a unique nine-digit identifier that is assigned to hazardous chemical substances.
regards EUGen