Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize CalendarValidatorTest.testFormat() #301

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sigee
Copy link

@sigee sigee commented Dec 26, 2024

CalendarValidatorTest.testFormat()

  • Ordered and separated test case blocks (for details see commit message)
  • Renamed variables
  • Reorganized statements
  • Remove unneeded DateFormat instances

CalendarValidatorTest.testCalendarValidatorMethods() & CalendarValidatorTest.testDateTimeStyle()

  • Replace "11" as magic number and "month is 0-based" comment with Calendar.DECEMBER constant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant