IGNITE-24036 Sql schema. Introduce QualifiedName class #4971
+532
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-24036
branch
from
75843ff to
ba05875
Compare
xtern
reviewed
Dec 26, 2024
modules/api/src/main/java/org/apache/ignite/table/QualifiedName.java
Outdated
Show resolved
Hide resolved
zstan
reviewed
Dec 27, 2024
| } | ||
|
|
||
| private static void verifyObjectName(@Nullable String name) { | ||
| if (name == null || name.isEmpty()) { |
There was a problem hiding this comment.
Suggested change
| if (name == null || name.isEmpty()) { | |
| if (org.apache.ignite.internal.util.StringUtils#nullOrEmpty(name)) { |
There was a problem hiding this comment.
Internal package from ignite-core module is not available in ignite-api module.
| * Unquoted name will be cast to upper case. E.g. "tbl0" - is equivalent to "TBL0", "\"Tbl0\"" - "Tbl0", etc. | ||
| */ | ||
| public class QualifiedName { | ||
| static final String DEFAULT_SCHEMA_NAME = "PUBLIC"; |
There was a problem hiding this comment.
plz also fix it here SqlCommon#DEFAULT_SCHEMA_NAME
| } | ||
|
|
||
| /** Normalized schema name. */ | ||
| private final String schemaIdentifier; |
There was a problem hiding this comment.
plz move it into beginning, just become more readable
| foundDot = false; | ||
| return ""; | ||
| } | ||
| throw new NoSuchElementException("No more tokens available."); |
There was a problem hiding this comment.
this exception can be returned through public api, but what does it mean from user point of view, may be it need be wrapped ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes