Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind 0.0.0.0 for all Thrift Service to enhance extensibility #14577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OneSizeFitsQuorum
Copy link
Contributor

image
image
Learn from other big data stacks

Signed-off-by: OneSizeFitQuorum <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@CritasWang CritasWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.40%. Comparing base (1a0d4c6) to head (6452e0d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...b/commons/service/AbstractThriftServiceThread.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14577      +/-   ##
============================================
- Coverage     39.42%   39.40%   -0.02%     
  Complexity      185      185              
============================================
  Files          4341     4341              
  Lines        275376   275376              
  Branches      33637    33637              
============================================
- Hits         108570   108523      -47     
- Misses       166806   166853      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants