-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support list server configs by admin cli tool #6702
base: master
Are you sure you want to change the base?
Conversation
ffbf547
to
d66a113
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6702 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 686 +2
Lines 42279 42324 +45
Branches 5765 5770 +5
======================================
- Misses 42279 42324 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
listing configurations should be restricted to admin only. additionally, we may need to have another parameter to define the display mode for configuration values, e.g.
PS: I remember there was a similar request to have a configuration display mode of configurations for retrieving batch info |
e47c9d0
to
d41fa7d
Compare
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
list config
in admin cli tool , for listing all the server configs, which is useful for checking runtime configs when before/after refreshing the configs of user-defaults or non-user-defaultsTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.