-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify DEV_ZERO config on Nuttx's built-in board #15223
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] No, this PR summary does not adequately meet the NuttX requirements. Here's why and how to fix it: Missing Information in Summary:
Missing Information in Impact:
Missing Information in Testing:
By providing this level of detail, reviewers can properly assess the PR and ensure it meets the project's standards. Conciseness is good, but not at the expense of clarity and completeness. |
31a4d6e
to
b4d5e66
Compare
4a4ab15
to
f3596ad
Compare
835b9b8
to
b4f93eb
Compare
@luckyyaojin /dev/null also should be enabled by default, it is very useful as /dev/zero |
b4f93eb
to
bb239de
Compare
let's create a new patch for this, @luckyyaojin |
@xiaoxiang781216 @acassis /dev/null is already enabled by default |
eac2376
to
53f7eb6
Compare
53f7eb6
to
fd23024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI error is in esp32c3-devkit/knsh
config:
Configuration/Tool: esp32c3-devkit/knsh
2024-12-22 09:31:23
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
Error: ./chip/esp32c3_region.c:44:4: error: #error "ESP32C3_REGION_PROTECTION shall not be enabled with Protected Mode"
44 | # error "ESP32C3_REGION_PROTECTION shall not be enabled with Protected Mode"
| ^~~~~
ERROR: riscv-none-elf-gcc failed: 1
Any ideas?
/dev/zero is a very commonly used config, for example use /dev/zero to test the filesystem, mtd or block devices performance. So let's default enable it when not enable DEFAULT_SMALL Signed-off-by: Bowen Wang <[email protected]>
fd23024
to
171862c
Compare
@hartmannathan |
171862c
to
0168791
Compare
@luckyyaojin could you check your change locally before updating patch by |
@xiaoxiang781216 I have already checked locally by the cmd 'tools/refresh.sh --silent all ' , let me check again |
0168791
to
20ee5cc
Compare
Signed-off-by: mazhuang <[email protected]>
20ee5cc
to
2240410
Compare
Note: Please adhere to Contributing Guidelines.
Summary
*/dev/zero is a very commonly used config, for example use
/dev/zero to test the filesystem, mtd or block devices performance.
So let's default enable it when not enable DEFAULT_SMALL
Impact
Nuttx's built-in boards' defconfig
Testing
CI