[SPARK-50678][BUILD] Clean up outdated style check rules related to Guava #49302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test first |
LuciferYang
changed the title
LuciferYang
commented
Dec 26, 2024
| <module name="RegexpSinglelineJava"> | ||
| <property name="format" value="Files\.createTempDir\("/> | ||
| <property name="message" | ||
| value="Avoid using com.google.common.io.Files.createTempDir() due to CVE-2020-8908. |
There was a problem hiding this comment.
cc @dongjoon-hyun
Do you think we can clean up these check rules now?
Are there any edge cases that I haven't considered? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The version of Guava being used by Spark is 33.3.1 now, so this pr cleans up the outdated check rules from
dev/checkstyle.xmlandscalastyle-config.xmlObjects.toStringHelpermethod, so this check rule is no longer neededWhy are the changes needed?
Clean up outdated style check rules related to Guava
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions
Was this patch authored or co-authored using generative AI tooling?
No