[SPARK-50691][SQL][FOLLOWUP] Use UnsafeProjection for LocalRelation rows instead of ComparableLocalRelation #49322
+18
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
changed the title
vladimirg-db
force-pushed
the
vladimirg-db/update-comparable-local-relation-to-cover-unsafe-row
branch
2 times, most recently
from
dedd6f9 to
2b9a993
Compare
vladimirg-db
changed the title
vladimirg-db
force-pushed
the
vladimirg-db/update-comparable-local-relation-to-cover-unsafe-row
branch
2 times, most recently
from
7ff35e4 to
4b402da
Compare
vladimirg-db
force-pushed
the
vladimirg-db/update-comparable-local-relation-to-cover-unsafe-row
branch
from
4b402da to
37c2ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
UnsafeProjectionforLocalRelationrows instead ofComparableLocalRelation.Why are the changes needed?
UnsafeRow.equalscompares the whole byte sequence under it, so it's a convenient way to compare all kind of row values, includingArrayBasedMapData.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test.
Was this patch authored or co-authored using generative AI tooling?
copilot.nvim.