[SPARK-50692] Add RPAD pushdown support #49325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V2ExpressionSQLBuilder: register RPAD as a visitSqlFunction
urosstan-db
approved these changes
Dec 27, 2024
|
cc @beliefer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes RPAD function translatable across connectors. Individual connectors can now support this via their dialects.
Why are the changes needed?
When trying to compare CHAR(...) and a literal, Spark injects a RPAD function to make the CHAR parameter the same length. This behaviour is per ANSI standard.
The problem is that RPAD is not only an unsupported, but an untranslatable function. This prevents CHAR + literal comparison pushdown.
Solution is to support RPAD pushdowns and implement it when needed
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR only introduces the ability to support the RPAD pushdown. Individual connectors will have their own tests.
Was this patch authored or co-authored using generative AI tooling?
No