-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes 5.0 approved legacy charts #31582
Draft
michael-s-molina
wants to merge
14
commits into
apache:master
Choose a base branch
from
michael-s-molina:remove-approved-legacy-charts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: Removes 5.0 approved legacy charts #31582
michael-s-molina
wants to merge
14
commits into
apache:master
from
michael-s-molina:remove-approved-legacy-charts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 5.0 breaking window, this PR executes the following proposals:
I decided to do it all in a single PR to have a single migration for the charts. There's also many code blocks that were removed that touches multiple visualization types at the same time and it would be more complex to remove it in parts. Another important factor was the ability to execute the tests once, given that we need to check if the example charts are loaded correctly. In summary, the benefits outweigh the review complexity.
TODO:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION